[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vdi: remove double conversion
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH] vdi: remove double conversion |
Date: |
Fri, 6 Jun 2014 16:14:54 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The Friday 06 Jun 2014 à 16:06:52 (+0200), Paolo Bonzini wrote :
> This should be a problem when running on big-endian machines.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> It's time to clean up old branch, and I found this nice little
> patch from May 2012.
>
> block/vdi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/vdi.c b/block/vdi.c
> index 119d3c7..993430e 100644
> --- a/block/vdi.c
> +++ b/block/vdi.c
> @@ -237,7 +237,6 @@ static void vdi_header_to_le(VdiHeader *header)
> cpu_to_le32s(&header->block_extra);
> cpu_to_le32s(&header->blocks_in_image);
> cpu_to_le32s(&header->blocks_allocated);
> - cpu_to_le32s(&header->blocks_allocated);
> uuid_convert(header->uuid_image);
> uuid_convert(header->uuid_last_snap);
> uuid_convert(header->uuid_link);
> --
> 1.8.3.1
>
>
Reviewed-by: Benoit Canet <address@hidden>