[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH memory v4 00/10] Memory Region QOMification
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH memory v4 00/10] Memory Region QOMification |
Date: |
Fri, 06 Jun 2014 16:52:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Il 06/06/2014 15:36, Peter Crosthwaite ha scritto:
However, I'd rather have the concept bake for a bit by starting with
read-only properties.
The just a matter of pulling our the setters?
Yes. You can leave in all the preparatory refactoring.
I guess it can be done
but I don't fully understand the motivation.
I'm not sure what the interactions should be between the setters and,
for example, the "realized" property. In addition, some memory regions
(for example PCI BARs) are meant to be moved around by the guest, not
the host.
By comparison, with getters only not many things can go wrong.
I think there are some concepts in the "container"
property that can be generalized.
Can you elaborate this a little more?
Basically the container property acts as a kind of "backdoor" to express
many:1 relations (which are a bit ugly to express with the current QOM
property model). If object X is on the 1 side and object Y is on the
"many" side, you then write the path to Y to a property of X.
There are obvious similarity between the container/address/visible
properties of a MemoryRegion are very similar to bus/addr/realized that
we have for -device. I think we should try and understand better what
this similarity means, and whether this approach to many:1 relations
could become a more central part of QOM.
Paolo
- [Qemu-devel] [PATCH memory v4 03/10] qom: object: Ignore refs/unrefs of NULL, (continued)
- [Qemu-devel] [PATCH memory v4 03/10] qom: object: Ignore refs/unrefs of NULL, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 04/10] qom: Publish object_resolve_link, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 05/10] memory: Coreify subregion add functionality, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 06/10] memory: MemoryRegion: factor out memory region re-adder, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 07/10] memory: MemoryRegion: QOMify, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 08/10] memory: MemoryRegion: Add container and addr props, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 09/10] memory: MemoryRegion: Add may-overlap and priority props, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 10/10] memory: MemoryRegion: Add size property, Peter Crosthwaite, 2014/06/06
- Re: [Qemu-devel] [PATCH memory v4 00/10] Memory Region QOMification, Paolo Bonzini, 2014/06/06