[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] vnc: Drop superfluous conditionals aroun
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] vnc: Drop superfluous conditionals around g_free() |
Date: |
Fri, 06 Jun 2014 19:11:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 06/06/2014 10:47 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> ui/vnc-tls.c | 6 ++----
>> ui/vnc.c | 12 ++++--------
>> 2 files changed, 6 insertions(+), 12 deletions(-)
>>
>> diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c
>> index 50275de..6392326 100644
>> --- a/ui/vnc-tls.c
>> +++ b/ui/vnc-tls.c
>> @@ -443,10 +443,8 @@ static int vnc_set_x509_credential(VncDisplay *vd,
>> {
>> struct stat sb;
>>
>> - if (*cred) {
>> - g_free(*cred);
>> - *cred = NULL;
>> - }
>> + g_free(*cred);
>> + *cred = NULL;
>>
>> *cred = g_malloc(strlen(certdir) + strlen(filename) + 2);
>
> Still a dead store
No deader than before my patch :)
Still, it's as good an opportunity to drop it as any. Gerd, would you
like a v3?