[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9 v3] FreeBSD-user: Implement print_sysctl() s
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 3/9 v3] FreeBSD-user: Implement print_sysctl() syscall |
Date: |
Sat, 7 Jun 2014 22:58:39 +0100 |
On 6 June 2014 14:49, Sean Bruno <address@hidden> wrote:
Your commit message is inaccurate -- this patch isn't
implementing a syscall, it's just adding support to QEMU's
strace code for it. Something like
"bsd-user: Implement strace support for 'syscall' syscall"
would be better.
If you fix that, then
Reviewed-by: Peter Maydell <address@hidden>
(I notice you haven't put in a Copyright: line when you added
the file header, but I'm a bit unconvinced that they're really
useful for anything so I think that's ok.)
thanks
-- PMM
- [Qemu-devel] [PATCH 0/9 v3] FreeBSD-user: breakout the BSDs, Sean Bruno, 2014/06/06
- [Qemu-devel] [PATCH 2/9 v3] FreeBSD-user: GPL v2 update and sylte/whitespace, Sean Bruno, 2014/06/06
- [Qemu-devel] [PATCH 3/9 v3] FreeBSD-user: Implement print_sysctl() syscall, Sean Bruno, 2014/06/06
- Re: [Qemu-devel] [PATCH 3/9 v3] FreeBSD-user: Implement print_sysctl() syscall,
Peter Maydell <=
- [Qemu-devel] [PATCH 6/9 v3] FreeBSD-user: Add __acl_* to the table of syscalls, Sean Bruno, 2014/06/06
- [Qemu-devel] [PATCH 5/9 v3] FreeBSD-user: Implement print_sysarch() syscall, Sean Bruno, 2014/06/06
- [Qemu-devel] [PATCH 1/9 v3] FreeBSD-user: add HOST_VARIANT_DIR for various *BSD dependent code, Sean Bruno, 2014/06/06
- [Qemu-devel] [PATCH 4/9 v3] FreeBSD-user: Implement print_ioctl() syscall, Sean Bruno, 2014/06/06
- [Qemu-devel] [PATCH 7/9 v3] FreeBSD-user: Add extattr_* to the table of syscalls, Sean Bruno, 2014/06/06