Re: [Qemu-devel] [PATCH] scsi-disk: fix bug in scsi_block_new_request() introduced by commit 137745c

[Paolo Bonzini]

Il 08/06/2014 19:22, Ulrich Obergfell ha scritto:
> This patch fixes a bug in scsi_block_new_request() that was introduced
> by commit 137745c5c60f083ec982fe9e861e8c16ebca1ba8. If the host cache
> is used - i.e. if BDRV_O_NOCACHE is _not_ set - the 'break' statement
> needs to be executed to 'fall back' to SG_IO.
>
> Signed-off-by: Ulrich Obergfell <address@hidden>
> ---
>  hw/scsi/scsi-disk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index 4bcef55..7e62dbd 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -2526,7 +2526,7 @@ static SCSIRequest *scsi_block_new_request(SCSIDevice *d, 
> uint32_t tag,
>          * ones (such as WRITE SAME or EXTENDED COPY, etc.).  So, without
>          * O_DIRECT everything must go through SG_IO.
>           */
> -        if (bdrv_get_flags(s->qdev.conf.bs) & BDRV_O_NOCACHE) {
> +        if (!(bdrv_get_flags(s->qdev.conf.bs) & BDRV_O_NOCACHE)) {
>              break;
>          }

Applied, thanks.

Paolo