[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/5] trace: Replace error with warning if event is no
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 3/5] trace: Replace error with warning if event is not defined |
Date: |
Mon, 9 Jun 2014 17:23:47 +0200 |
From: Alexey Kardashevskiy <address@hidden>
At the moment QEMU exits if trace point is not defined which makes
a developer life harder if he has to switch between branches with
different traces implemented.
This replaces error+exit wit WARNING if the tracepoint does not exist or
not traceable.
Signed-off-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
trace/control.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/trace/control.c b/trace/control.c
index 49f61e1..4aa02cf 100644
--- a/trace/control.c
+++ b/trace/control.c
@@ -112,15 +112,15 @@ void trace_backend_init_events(const char *fname)
TraceEvent *ev = trace_event_name(line_ptr);
if (ev == NULL) {
fprintf(stderr,
- "error: trace event '%s' does not exist\n",
line_ptr);
- exit(1);
- }
- if (!trace_event_get_state_static(ev)) {
+ "WARNING: trace event '%s' does not exist\n",
+ line_ptr);
+ } else if (!trace_event_get_state_static(ev)) {
fprintf(stderr,
- "error: trace event '%s' is not traceable\n",
line_ptr);
- exit(1);
+ "WARNING: trace event '%s' is not traceable\n",
+ line_ptr);
+ } else {
+ trace_event_set_state_dynamic(ev, enable);
}
- trace_event_set_state_dynamic(ev, enable);
}
}
}
--
1.9.3
- [Qemu-devel] [PULL v2 0/5] Tracing pull request, Stefan Hajnoczi, 2014/06/09
- [Qemu-devel] [PULL 1/5] trace: add pid field to simpletrace record, Stefan Hajnoczi, 2014/06/09
- [Qemu-devel] [PULL 2/5] simpletrace: add support for trace record pid field, Stefan Hajnoczi, 2014/06/09
- [Qemu-devel] [PULL 3/5] trace: Replace error with warning if event is not defined,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 5/5] trace: Replace fprintf with error_report and print location, Stefan Hajnoczi, 2014/06/09
- [Qemu-devel] [PULL 4/5] trace: Multi-backend tracing, Stefan Hajnoczi, 2014/06/09
- Re: [Qemu-devel] [PULL v2 0/5] Tracing pull request, Peter Maydell, 2014/06/09