[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 12/29] numa: add -numa node, memdev= option
From: |
Hu Tao |
Subject: |
Re: [Qemu-devel] [PATCH v4 12/29] numa: add -numa node, memdev= option |
Date: |
Tue, 10 Jun 2014 10:23:44 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jun 09, 2014 at 11:22:05AM -0600, Eric Blake wrote:
> On 06/09/2014 04:25 AM, Hu Tao wrote:
> > From: Paolo Bonzini <address@hidden>
> >
> > This option provides the infrastructure for binding guest NUMA nodes
> > to host NUMA nodes. For example:
> >
> > -object memory-ram,size=1024M,policy=bind,host-nodes=0,id=ram-node0 \
> > -numa node,nodeid=0,cpus=0,memdev=ram-node0 \
> > -object
> > memory-ram,size=1024M,policy=interleave,host-nodes=1-3,id=ram-node1 \
> > -numa node,nodeid=1,cpus=1,memdev=ram-node1
> >
> > The option replaces "-numa node,mem=".
> >
> > Signed-off-by: Paolo Bonzini <address@hidden>
> > Signed-off-by: Hu Tao <address@hidden>
> > ---
> > include/sysemu/sysemu.h | 1 +
>
> > +# @mem: #optional memory size of this node; mutually exclusive with
> > @memdev.
> > +# Equally divide total memory among nodes if both @mem and @memdev
> > are
> > +# omitted.
> > +#
> > +# @memdev: #optional memory backend object. If specified for one node,
> > +# it must be specified for all nodes.
> > #
> > # Since: 2.1
> > ##
> > @@ -4753,4 +4757,5 @@
> > 'data': {
> > '*nodeid': 'uint16',
> > '*cpus': ['uint16'],
> > - '*mem': 'size' }}
> > + '*mem': 'size',
> > + '*memdev': 'str' }}
>
> This looks okay.
>
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index d3cd2ce..e448d33 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -95,16 +95,20 @@ specifies the maximum number of hotpluggable CPUs.
> > ETEXI
> >
> > DEF("numa", HAS_ARG, QEMU_OPTION_numa,
> > - "-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]\n",
> > QEMU_ARCH_ALL)
> > + "-numa node[,mem=size][,memdev=id][,cpus=cpu[-cpu]][,nodeid=node]\n",
> > QEMU_ARCH_ALL)
>
> But this implies both parameters can be used at once. Is it worth
> rewriting in two lines:
>
> "-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]\n"
> "-numa node[,memdev=id][,cpus=cpu[-cpu]][,nodeid=node]\n"
>
> to make the exclusion clearer?
OK.
>
>
> > -to allocate RAM and vCPUs respectively.
> > +to allocate RAM and vCPU srespectively, and possibly @option{-object}
>
> s/vCPU srespectively/vCPUs respectively/
:-P
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
- Re: [Qemu-devel] [PATCH v4 08/29] qmp: improve error reporting for -object and object-add, (continued)
- [Qemu-devel] [PATCH v4 09/29] pc: pass MachineState to pc_memory_init, Hu Tao, 2014/06/09
- [Qemu-devel] [PATCH v4 10/29] numa: introduce memory_region_allocate_system_memory, Hu Tao, 2014/06/09
- [Qemu-devel] [PATCH v4 11/29] hostmem: separate allocation from UserCreatable complete method, Hu Tao, 2014/06/09
- [Qemu-devel] [PATCH v4 12/29] numa: add -numa node,memdev= option, Hu Tao, 2014/06/09
- [Qemu-devel] [PATCH v4 13/29] memory: reorganize file-based allocation, Hu Tao, 2014/06/09
- [Qemu-devel] [PATCH v4 14/29] memory: move mem_path handling to memory_region_allocate_system_memory, Hu Tao, 2014/06/09
- [Qemu-devel] [PATCH v4 15/29] memory: add error propagation to file-based RAM allocation, Hu Tao, 2014/06/09
- [Qemu-devel] [PATCH v4 16/29] memory: move preallocation code out of exec.c, Hu Tao, 2014/06/09
- [Qemu-devel] [PATCH v4 17/29] memory: move RAM_PREALLOC_MASK to exec.c, rename, Hu Tao, 2014/06/09
- [Qemu-devel] [PATCH v4 18/29] hostmem: add file-based HostMemoryBackend, Hu Tao, 2014/06/09