Re: [Qemu-devel] [PATCH RESEND] migration: catch unknown flags in ram_load

[Amit Shah]

On (Tue) 03 Jun 2014 [18:27:15], Dr. David Alan Gilbert wrote:
> * Peter Lieven (address@hidden) wrote:
> > if a saved vm has unknown flags in the memory data qemu
> > currently simply ignores this flag and continues which
> > yields in an unpredictable result.
> > 
> > this patch catches all unknown flags and
> > aborts the loading of the vm.
> 
> Yes, I think that's quite nice - the only thing I'd add which would help
> a little is an error_report() in the case where you have invalid flags
> to let you know that's the reason for the EINVAL.
> 
> (Having spent the day tracking down migration bugs...)

Peter, can you please add these before we pick the patch up?

Thanks,

                Amit