[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 08/16] hostmem: add file-based HostMemoryBack
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v5 08/16] hostmem: add file-based HostMemoryBackend |
Date: |
Wed, 11 Jun 2014 11:03:43 +0300 |
On Tue, Jun 10, 2014 at 07:15:21PM +0800, Hu Tao wrote:
> From: Paolo Bonzini <address@hidden>
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Hu Tao <address@hidden>
> ---
> backends/Makefile.objs | 1 +
> backends/hostmem-file.c | 107
> ++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 108 insertions(+)
> create mode 100644 backends/hostmem-file.c
>
> diff --git a/backends/Makefile.objs b/backends/Makefile.objs
> index 7fb7acd..506a46c 100644
> --- a/backends/Makefile.objs
> +++ b/backends/Makefile.objs
> @@ -8,3 +8,4 @@ baum.o-cflags := $(SDL_CFLAGS)
> common-obj-$(CONFIG_TPM) += tpm.o
>
> common-obj-y += hostmem.o hostmem-ram.o
> +common-obj-$(CONFIG_LINUX) += hostmem-file.o
> diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
> new file mode 100644
> index 0000000..9b75314
> --- /dev/null
> +++ b/backends/hostmem-file.c
> @@ -0,0 +1,107 @@
> +/*
> + * QEMU Host Memory Backend for hugetlbfs
> + *
> + * Copyright (C) 2013 Red Hat Inc
I tweaked copyright to 2013-2014 here.
Not too important since the full history is in the git log, but still.
> + *
> + * Authors:
> + * Paolo Bonzini <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
> +#include "sysemu/hostmem.h"
> +#include "qom/object_interfaces.h"
> +
> +/* hostmem-file.c */
> +/**
> + * @TYPE_MEMORY_BACKEND_FILE:
> + * name of backend that uses mmap on a file descriptor
> + */
> +#define TYPE_MEMORY_BACKEND_FILE "memory-backend-file"
> +
> +#define MEMORY_BACKEND_FILE(obj) \
> + OBJECT_CHECK(HostMemoryBackendFile, (obj), TYPE_MEMORY_BACKEND_FILE)
> +
> +typedef struct HostMemoryBackendFile HostMemoryBackendFile;
> +
> +struct HostMemoryBackendFile {
> + HostMemoryBackend parent_obj;
> + char *mem_path;
> +};
> +
> +static void
> +file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
> +{
> + HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(backend);
> +
> + if (!backend->size) {
> + error_setg(errp, "can't create backend with size 0");
> + return;
> + }
> + if (!fb->mem_path) {
> + error_setg(errp, "mem_path property not set");
> + return;
> + }
> +#ifndef CONFIG_LINUX
> + error_setg(errp, "-mem-path not supported on this host");
> +#else
> + if (!memory_region_size(&backend->mr)) {
> + memory_region_init_ram_from_file(&backend->mr, OBJECT(backend),
> + object_get_canonical_path(OBJECT(backend)),
> + backend->size,
> + fb->mem_path, errp);
> + }
> +#endif
> +}
> +
> +static void
> +file_backend_class_init(ObjectClass *oc, void *data)
> +{
> + HostMemoryBackendClass *bc = MEMORY_BACKEND_CLASS(oc);
> +
> + bc->alloc = file_backend_memory_alloc;
> +}
> +
> +static char *get_mem_path(Object *o, Error **errp)
> +{
> + HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
> +
> + return g_strdup(fb->mem_path);
> +}
> +
> +static void set_mem_path(Object *o, const char *str, Error **errp)
> +{
> + HostMemoryBackend *backend = MEMORY_BACKEND(o);
> + HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
> +
> + if (memory_region_size(&backend->mr)) {
> + error_setg(errp, "cannot change property value");
> + return;
> + }
> + if (fb->mem_path) {
> + g_free(fb->mem_path);
> + }
> + fb->mem_path = g_strdup(str);
> +}
> +
> +static void
> +file_backend_instance_init(Object *o)
> +{
> + object_property_add_str(o, "mem-path", get_mem_path,
> + set_mem_path, NULL);
> +}
> +
> +static const TypeInfo file_backend_info = {
> + .name = TYPE_MEMORY_BACKEND_FILE,
> + .parent = TYPE_MEMORY_BACKEND,
> + .class_init = file_backend_class_init,
> + .instance_init = file_backend_instance_init,
> + .instance_size = sizeof(HostMemoryBackendFile),
> +};
> +
> +static void register_types(void)
> +{
> + type_register_static(&file_backend_info);
> +}
> +
> +type_init(register_types);
> --
> 1.9.3
- [Qemu-devel] [PATCH v5 01/16] fixup! NUMA: check if the total numa memory size is equal to ram_size, (continued)
- [Qemu-devel] [PATCH v5 01/16] fixup! NUMA: check if the total numa memory size is equal to ram_size, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 02/16] vl: redo -object parsing, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 03/16] fixup! qmp: improve error reporting for -object and object-add, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 04/16] pc: pass MachineState to pc_memory_init, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 05/16] backend:hostmem: replace hostmemory with host_memory, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 06/16] hostmem: separate allocation from UserCreatable complete method, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 07/16] fixup! numa: add -numa node, memdev= option, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 08/16] hostmem: add file-based HostMemoryBackend, Hu Tao, 2014/06/10
- Re: [Qemu-devel] [PATCH v5 08/16] hostmem: add file-based HostMemoryBackend,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH v5 09/16] hostmem: add merge and dump properties, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 10/16] hostmem: allow preallocation of any memory region, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 11/16] hostmem: add property to map memory with MAP_SHARED, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 12/16] hostmem: add properties for NUMA memory policy, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 13/16] tests: fix memory leak in test of string input visitor, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 14/16] qapi: make string input visitor parse int list, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 15/16] qapi: make string output visitor parse int list, Hu Tao, 2014/06/10
- [Qemu-devel] [PATCH v5 16/16] qmp: add query-memdev, Hu Tao, 2014/06/10
- Re: [Qemu-devel] [PATCH v5 00/16] NUMA series v5, Michael S. Tsirkin, 2014/06/12