Re: [Qemu-devel] [PATCH 3/9] block: Move json: parsing to bdrv_fill_options()

[Eric Blake]

On 06/12/2014 06:26 AM, Benoît Canet wrote:

>> +static QDict *parse_json_filename(const char *filename, Error **errp)
>> +{

> 
> I am under the impression that this code move could be avoided by using a 
> function
> prototype: the patch would be less cluttered.

I'm a fan of avoiding function prototypes for static functions when
possible (listing things in topological order is nicer for someone
reading the file for the first time - prototypes only help for recursive
functions), so I'm in favor of keeping the code motion.  But splitting
code motion into its own patch rather than mixing it with other changes
is nicer on reviewers.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature