Re: [Qemu-devel] [PATCH] audio: Fix using freed pointer in wav_fini_out

[Peter Maydell]

On 13 June 2014 08:15, Markus Armbruster <address@hidden> wrote:
> <address@hidden> writes:
>
>> From: Gonglei <address@hidden>
>>
>> Spotted by Coverity:
>>
>> (8) Event freed_arg:  "fclose(FILE *)" frees "wav->f".
>> (9) Event cond_true:  Condition "fclose(wav->f)", taking true branch
>> Also see events:  [pass_freed_arg]
>>
>> 212         if (fclose (wav->f))  {
>> (10) Event pass_freed_arg:  Passing freed pointer "wav->f" as an argument
>> to function "AUD_log(char const *, char const *, ...)".
>> Also see events:  [freed_arg]
>>
>> 213             dolog ("wav_fini_out: fclose %p failed\nReason: %s\n",
>> 214                    wav->f, strerror (errno));
>
> False positive, because dolog() doesn't dereference wav->f, it only
> prints it.

Yep, I pointed that out last time around...

thanks
-- PMM