[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V6 04/29] test: add test cases for qapi event
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V6 04/29] test: add test cases for qapi event |
Date: |
Fri, 13 Jun 2014 11:05:36 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 06/05/2014 06:21 AM, Wenchao Xia wrote:
> These cases will verify whether the expected qdict is built.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> tests/Makefile | 16 ++-
> tests/qapi-schema/qapi-schema-test.json | 12 ++
> tests/qapi-schema/qapi-schema-test.out | 10 +-
> tests/test-qmp-event.c | 265
> +++++++++++++++++++++++++++++++
> 4 files changed, 298 insertions(+), 5 deletions(-)
> create mode 100644 tests/test-qmp-event.c
>
> +
> + /* Verify that we have timestamp, then remove it to compare other field
> */
s/field/fields/
Minor enough to include that as part of your followup patch to the whole
series.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V6 00/29] add direct support of event in qapi schema, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 01/29] os-posix: include sys/time.h, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 02/29] qapi: add event helper functions, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 03/29] qapi script: add event support, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 04/29] test: add test cases for qapi event, Wenchao Xia, 2014/06/05
- Re: [Qemu-devel] [PATCH V6 04/29] test: add test cases for qapi event,
Eric Blake <=
- [Qemu-devel] [PATCH V6 05/29] qapi: adjust existing defines, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 06/29] monitor: add an implemention as qapi event emit method, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 07/29] qapi: add new schema file qapi-event.json, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 08/29] qapi event: convert SHUTDOWN, Wenchao Xia, 2014/06/05