[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V6 09/29] qapi event: convert POWERDOWN
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V6 09/29] qapi event: convert POWERDOWN |
Date: |
Fri, 13 Jun 2014 14:02:01 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 06/05/2014 06:22 AM, Wenchao Xia wrote:
> There is no existing comments for POWERDOWN in doc/qmp/qmp-events.txt,
> so no change on it like other conversion patch.
Oddly enough, POWERDOWN _is_ documented in docs/qmp/qmp-spec.txt, but
that reference doesn't need updating with this conversion.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> qapi-event.json | 10 ++++++++++
> vl.c | 2 +-
> 2 files changed, 11 insertions(+), 1 deletions(-)
> +++ b/vl.c
> @@ -1991,7 +1991,7 @@ void qemu_system_shutdown_request(void)
>
> static void qemu_system_powerdown(void)
> {
> - monitor_protocol_event(QEVENT_POWERDOWN, NULL);
> + qapi_event_send_powerdown(NULL);
Modulo my comment in 8/29 on whether we even need an errp argument,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V6 06/29] monitor: add an implemention as qapi event emit method, (continued)
- [Qemu-devel] [PATCH V6 06/29] monitor: add an implemention as qapi event emit method, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 07/29] qapi: add new schema file qapi-event.json, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 08/29] qapi event: convert SHUTDOWN, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 09/29] qapi event: convert POWERDOWN, Wenchao Xia, 2014/06/05
- Re: [Qemu-devel] [PATCH V6 09/29] qapi event: convert POWERDOWN,
Eric Blake <=
- [Qemu-devel] [PATCH V6 10/29] qapi event: convert RESET, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 11/29] qapi event: convert STOP, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 12/29] qapi event: convert RESUME, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 13/29] qapi event: convert SUSPEND, Wenchao Xia, 2014/06/05
- [Qemu-devel] [PATCH V6 14/29] qapi event: convert SUSPEND_DISK, Wenchao Xia, 2014/06/05