Re: [Qemu-devel] [PATCH v2 2/4] check if we have space left for hotplugged memory

[Igor Mammedov]

On Mon, 16 Jun 2014 18:05:42 +0800
Hu Tao <address@hidden> wrote:

> If pc-dimm is specified on qemu command line, but only with
> -m size (aka not -m size,maxmem,slots) then qemu will core dump.
> 
> This patch fixes the problem.
> 
> Signed-off-by: Hu Tao <address@hidden>
> ---
>  hw/mem/pc-dimm.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
> index 8c26568..a57b9a3 100644
> --- a/hw/mem/pc-dimm.c
> +++ b/hw/mem/pc-dimm.c
> @@ -107,6 +107,13 @@ uint64_t pc_dimm_get_free_addr(uint64_t 
> address_space_start,
>      uint64_t new_addr, ret = 0;
>      uint64_t address_space_end = address_space_start + address_space_size;
>  
> +    if (address_space_size == 0) {
> +        error_setg(errp, "no space left for hotplugged memory. did you 
> forget "
> +                   "maxmem and slots on "
> +                   "-m(aka -m size,maxmem=maxmem,slots=slots)?");
CLI format here could get out off sync from actual one. Maybe just
"no space left in hotplug memory range" 

> +        goto out;
> +    }
> +
>      assert(address_space_end > address_space_size);
>      object_child_foreach(qdev_get_machine(), pc_dimm_built_list, &list);
>