qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes
Date: Tue, 17 Jun 2014 06:31:01 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 17/06/2014 00:35, Alexander Graf ha scritto:

On 16.06.14 19:29, Gabriel L. Somlo wrote:
This series contains a few fixes and improvements in the emulation
of link auto-negotiation:

   - use auto-negotiation when the link is bounced externally (e.g. via
     set_link <foo> down/up on the qemu monitor command line).

   - allow mii_tool on linux access to all the phy registers and flags
     it requires in order to report a successfully auto-negotiated link.

   - inject LSC interrupt upon successful link auto-negotiation (required
     by stock OS X e1000 driver).

See additional prose following commit logs in 2/3 (making up excuses
for checkpatch error) and 3/3 (further thoughts on OS X vs. Linux/Windows
re. auto-negotiation and LSC injection).

Looks very reasonable and straight forward to me.

Reviewed-by: Alexander Graf <address@hidden>

Would you pick it up and send a pull request for it?

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]