[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/18] migration: add static analysis tool to
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/18] migration: add static analysis tool to check vmstate compat |
Date: |
Tue, 17 Jun 2014 09:25:12 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/17/2014 07:59 AM, Amit Shah wrote:
> On (Tue) 17 Jun 2014 [07:34:07], Eric Blake wrote:
>>
>>
>> On 06/17/2014 07:19 AM, Amit Shah wrote:
>>> Hello,
>>>
>>> v3:
>>> - Python script returns an error code: 0 if no errors, positive for
>>> the number of errors identified.
>>
>> Returning the error count as $? is unreliable - if you have exactly 256
>> errors, that gives the same status as if you had success. Does your
>> code guarantee non-zero return in that case?
>
> No; any good ideas for this, then? Just limit to 255, and never bump
> upwards?
Yes, saturating math (capping at 255) is sufficient; in the normal case,
we won't have that many errors.
>
> I'm only introducing this so that future integration with 'make check'
> can be noticed by scripts.
And for that, all we need is a non-zero status.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 11/18] tests: vmstate static checker: change description name, (continued)
- [Qemu-devel] [PATCH v3 11/18] tests: vmstate static checker: change description name, Amit Shah, 2014/06/17
- [Qemu-devel] [PATCH v3 12/18] tests: vmstate static checker: remove Fields, Amit Shah, 2014/06/17
- [Qemu-devel] [PATCH v3 13/18] tests: vmstate static checker: remove Description, Amit Shah, 2014/06/17
- [Qemu-devel] [PATCH v3 14/18] tests: vmstate static checker: remove Description inside Fields, Amit Shah, 2014/06/17
- [Qemu-devel] [PATCH v3 15/18] tests: vmstate static checker: remove a subsection, Amit Shah, 2014/06/17
- [Qemu-devel] [PATCH v3 16/18] tests: vmstate static checker: remove Subsections, Amit Shah, 2014/06/17
- [Qemu-devel] [PATCH v3 18/18] tests: vmstate static checker: add size mismatch inside substructure, Amit Shah, 2014/06/17
- [Qemu-devel] [PATCH v3 17/18] tests: vmstate static checker: add substructure for usb-kbd for hid section, Amit Shah, 2014/06/17
- Re: [Qemu-devel] [PATCH v3 00/18] migration: add static analysis tool to check vmstate compat, Eric Blake, 2014/06/17