Re: [Qemu-devel] [PATCH v10 4/4] qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror node-name mode.

[Benoît Canet]

The Tuesday 17 Jun 2014 à 18:17:46 (+0200), Max Reitz wrote :
> On 16.06.2014 12:00, Benoît Canet wrote:
> >The to-replace-node-name is designed to allow repairing a broken Quorum file.
> >This patch introduces a new class TestRepairQuorum testing that the feature
> >works.
> >Some further work will be done on QEMU to improve the robustness of the 
> >tests.
> >
> >Signed-off-by: Benoit Canet <address@hidden>
> >---
> >  tests/qemu-iotests/041     | 196 
> > ++++++++++++++++++++++++++++++++++++++++++++-
> >  tests/qemu-iotests/041.out |   4 +-
> >  2 files changed, 194 insertions(+), 6 deletions(-)
> 
> The test looks fine in general and it does work, so I would give it
> a reviewed-by. However, I still have some open questions from v9
> about why this test works, so I'll still wait. ;-)

It works because node name is a linked list so the insertion order make the
positions in the json predictible.


> 
> Max