[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 011/103] pc-dimm: do not allow to set already use
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PULL 011/103] pc-dimm: do not allow to set already used memdev |
|
Date: |
Tue, 17 Jun 2014 21:42:57 +0300 |
On Tue, Jun 17, 2014 at 12:39:32PM -0600, Eric Blake wrote:
> On 06/17/2014 11:36 AM, Michael S. Tsirkin wrote:
> > From: Igor Mammedov <address@hidden>
> >
> > using the same memdev backend more than once will cause
> > assersion at MemoryRegion mapping time becase it's already
>
> s/assersion/assertion/; s/becase/because/
> (but probably too late now that this is a pull request)
Absolutely too late.
I don't mind spelling errors in commit logs too much, they
don't show up in code. If noted in time I fix them in place ...
> > mapped. Prevent it by checking that associated MemoryRegion
> > is not mapped.
> >
> > Signed-off-by: Igor Mammedov <address@hidden>
> > Acked-by: Peter Crosthwaite <address@hidden>
> > Reviewed-by: Michael S. Tsirkin <address@hidden>
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > ---
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
- [Qemu-devel] [PULL 001/103] pc: create custom generic PC machine type, (continued)
- [Qemu-devel] [PULL 001/103] pc: create custom generic PC machine type, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 003/103] object_add: allow completion handler to get canonical path, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 004/103] vl.c: daemonize before guest memory allocation, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 005/103] add memdev backend infrastructure, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 006/103] vl.c: extend -m option to support options for memory hotplug, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 007/103] qdev: hotplug for buss-less devices, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 002/103] pc: ACPI BIOS: use enum for defining memory affinity flags, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 008/103] qdev: expose DeviceState.hotplugged field as a property, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 011/103] pc-dimm: do not allow to set already used memdev, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 010/103] memory: add memory_region_is_mapped() API, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 009/103] pc: implement pc-dimm device abstraction, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 014/103] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 015/103] pc: exit QEMU if compat machine doesn't support memory hotlpug, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 013/103] pc: exit QEMU if number of slots more than supported 256, Michael S. Tsirkin, 2014/06/17