[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 7/9] virtio-blk: drop virtio_blk_set_conf()
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH v4 7/9] virtio-blk: drop virtio_blk_set_conf() |
Date: |
Wed, 18 Jun 2014 17:58:34 +0800 |
This function is no longer used since parent objects now use child
aliases to set the VirtIOBlkConf directly.
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
---
hw/block/virtio-blk.c | 6 ------
include/hw/virtio/virtio-blk.h | 2 --
2 files changed, 8 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 85aa871..cfb8fa3 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -655,12 +655,6 @@ static const BlockDevOps virtio_block_ops = {
.resize_cb = virtio_blk_resize,
};
-void virtio_blk_set_conf(DeviceState *dev, VirtIOBlkConf *blk)
-{
- VirtIOBlock *s = VIRTIO_BLK(dev);
- memcpy(&(s->blk), blk, sizeof(struct VirtIOBlkConf));
-}
-
#ifdef CONFIG_VIRTIO_BLK_DATA_PLANE
/* Disable dataplane thread during live migration since it does not
* update the dirty memory bitmap yet.
diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h
index 56c98b1..59cf1f2 100644
--- a/include/hw/virtio/virtio-blk.h
+++ b/include/hw/virtio/virtio-blk.h
@@ -159,8 +159,6 @@ typedef struct VirtIOBlock {
DEFINE_PROP_BIT("config-wce", _state, _field.config_wce, 0, true), \
DEFINE_PROP_IOTHREAD("x-iothread", _state, _field.iothread)
-void virtio_blk_set_conf(DeviceState *dev, VirtIOBlkConf *blk);
-
int virtio_blk_handle_scsi_req(VirtIOBlock *blk,
VirtQueueElement *elem);
--
1.9.3
- [Qemu-devel] [PATCH v4 0/9] virtio-blk: use alias properties in transport devices, Stefan Hajnoczi, 2014/06/18
- [Qemu-devel] [PATCH v4 1/9] qom: add object_property_add_alias(), Stefan Hajnoczi, 2014/06/18
- [Qemu-devel] [PATCH v4 2/9] virtio-blk: avoid qdev property definition duplication, Stefan Hajnoczi, 2014/06/18
- [Qemu-devel] [PATCH v4 3/9] dataplane: bail out on unsupported transport, Stefan Hajnoczi, 2014/06/18
- [Qemu-devel] [PATCH v4 4/9] virtio-blk: move x-data-plane qdev property to virtio-blk.h, Stefan Hajnoczi, 2014/06/18
- [Qemu-devel] [PATCH v4 5/9] qdev: add qdev_alias_all_properties(), Stefan Hajnoczi, 2014/06/18
- [Qemu-devel] [PATCH v4 6/9] virtio-blk: use aliases instead of duplicate qdev properties, Stefan Hajnoczi, 2014/06/18
- [Qemu-devel] [PATCH v4 7/9] virtio-blk: drop virtio_blk_set_conf(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v4 8/9] virtio: fix virtio-blk child refcount in transports, Stefan Hajnoczi, 2014/06/18
- [Qemu-devel] [PATCH v4 9/9] virtio-blk: move qdev properties into virtio-blk.c, Stefan Hajnoczi, 2014/06/18
- Re: [Qemu-devel] [PATCH v4 0/9] virtio-blk: use alias properties in transport devices, Paolo Bonzini, 2014/06/24
- Re: [Qemu-devel] [PATCH v4 0/9] virtio-blk: use alias properties in transport devices, Stefan Hajnoczi, 2014/06/30