[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 01/18] migration: dump vmstate info as a json
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v4 01/18] migration: dump vmstate info as a json file for static analysis |
Date: |
Wed, 18 Jun 2014 12:56:54 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Amit Shah <address@hidden> wrote:
>>
>> You can print always \n now, right?
>
> There's also a , there...
>
> This sequence was added recently (v2 onwards) for the ignoring of the
> VMS_MUST_EXIST stuff.
I knew it needed to be some reason for the ugliness :-()
>> Same for the other places? Or I am missing something.
>>
>> I will even go that itwould be better to just left the \n on the (*),
>> and just add this \n at the end of writing a subsection.
>>
>>
>> > + fprintf(out_file, "\n%*s}", indent - 2, "");
>>
>> And you remove it from here.
>
> I tried several things with the \n; the current setting is the best I
> found.
>
> Of course, this is just pretty-printing, so I don't actually remember
> all the details but I can look it up my git tree...
ok, I retire the comment, and anyways, it is trivial to fix
incrementally if you/anybody came with a clever idea.
Reviewed-by: Juan Quintela <address@hidden>
[Qemu-devel] [PATCH v4 03/18] tests: vmstate static checker: add dump1 and dump2 files, Amit Shah, 2014/06/18
[Qemu-devel] [PATCH v4 04/18] tests: vmstate static checker: incompat machine types, Amit Shah, 2014/06/18
[Qemu-devel] [PATCH v4 05/18] tests: vmstate static checker: add version error in main section, Amit Shah, 2014/06/18