[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 for 2.1 08/10] block: add backing-file option
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v6 for 2.1 08/10] block: add backing-file option to block-stream |
Date: |
Thu, 19 Jun 2014 16:04:24 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Jun 17, 2014 at 05:53:56PM -0400, Jeff Cody wrote:
> On some image chains, QEMU may not always be able to resolve the
> filenames properly, when updating the backing file of an image
> after a block job.
>
> For instance, certain relative pathnames may fail, or drives may
> have been specified originally by file descriptor (e.g. /dev/fd/???),
> or a relative protocol pathname may have been used.
>
> In these instances, QEMU may lack the information to be able to make
> the correct choice, but the user or management layer most likely does
> have that knowledge.
>
> With this extension to the block-stream api, the user is able to change
> the backing file of the active layer as part of the block-stream
> operation.
>
> This allows the change to be 'safe', in the sense that if the attempt
> to write the active image metadata fails, then the block-stream
> operation returns failure, without disrupting the guest.
>
> If a backing file string is not specified in the command, the backing
> file string to use is determined in the same manner as it was
> previously.
>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> block/stream.c | 11 +++++------
> blockdev.c | 12 ++++++++++++
> hmp.c | 3 ++-
> qapi/block-core.json | 18 +++++++++++++++++-
> qmp-commands.hx | 2 +-
> 5 files changed, 37 insertions(+), 9 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpAmPTc66LfV.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH v6 for 2.1 04/10] block: make 'top' argument to block-commit optional, (continued)
- [Qemu-devel] [PATCH v6 for 2.1 05/10] block: Accept node-name arguments for block-commit, Jeff Cody, 2014/06/17
- [Qemu-devel] [PATCH v6 for 2.1 06/10] block: extend block-commit to accept a string for the backing file, Jeff Cody, 2014/06/17
- [Qemu-devel] [PATCH v6 for 2.1 07/10] block: add ability for block-stream to use node-name, Jeff Cody, 2014/06/17
- [Qemu-devel] [PATCH v6 for 2.1 08/10] block: add backing-file option to block-stream, Jeff Cody, 2014/06/17
- Re: [Qemu-devel] [PATCH v6 for 2.1 08/10] block: add backing-file option to block-stream,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v6 for 2.1 09/10] block: Add QMP documentation for block-stream, Jeff Cody, 2014/06/17
- [Qemu-devel] [PATCH v6 for 2.1 10/10] block: add QAPI command to allow live backing file change, Jeff Cody, 2014/06/17
- Re: [Qemu-devel] [PATCH v6 for 2.1 10/10] block: add QAPI command to allow live backing file change, Stefan Hajnoczi, 2014/06/19
- Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names, Stefan Hajnoczi, 2014/06/19