[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] w32: Fix regression caused by new g_poll imp
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH v2] w32: Fix regression caused by new g_poll implementation |
Date: |
Thu, 19 Jun 2014 13:31:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Am 19.06.2014 10:55, schrieb Peter Maydell:
> On 28 May 2014 16:42, Stefan Weil <address@hidden> wrote:
>> Commit 5a007547df76446ab891df93ebc55749716609bf tried to fix a
>> performance degradation caused by bad handling of small timeouts
>> in the original implementation of g_poll.
>>
>> Since that commit, hard disk I/O no longer works.
>>
>> Instead of rewriting the g_poll implementation, this patch simply copies
>> the original code (released under LGPL) from latest glib and only modifies
>> it where needed (see comments in the code). URL of the original code:
>> https://git.gnome.org/browse/glib/tree/glib/gpoll.c
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>>
>> v2: Adjust top-of-file comment to indicate which parts of the code use
>> a different license (LGPL2+ is incompatible with the original license
>> used for util/oslib-win32.c).
>
> Reviewed-by: Peter Maydell <address@hidden>
>
> Oops, I'd forgotten about this (until I needed to do
> something with the Windows build ;-)). Are you planning
> a pullreq for it or do you want me to just apply it directly?
>
> thanks
> -- PMM
Please apply it directly.
Thanks,
Stefan