Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

[Andreas Färber]

Hi Gerd,

Am 19.06.2014 12:05, schrieb Gerd Hoffmann:
>> Gonglei (5):
>>   tests: add OHCI qtest
>>   tests: add UHCI qtest
>>   tests: add xHCI qtest
>>   usb-hcd-ehci-test: change ehci qtest more expansively
>>   usb-hcd-ehci-test: add ehci hotplug/unplug qtest
> 
> I'd prefer to leave the usb-hcd-ehci-test alone.

Why? My idea was to put all EHCI testing code into that ehci file. This
is so that any defines or helper functions can be shared within the
file. Functional testing of the companion core should go into the
respective *hci file, unless there is some interaction to test.

Just because right now most test files are pretty empty doesn't mean
they need to stay that way.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg