Re: [Qemu-devel] [PATCH v8 17/20] virtio-scsi: use virtio wrappers to access headers

[Greg Kurz]

On Fri, 20 Jun 2014 10:24:43 +0200
Paolo Bonzini <address@hidden> wrote:

> Il 13/06/2014 13:24, Greg Kurz ha scritto:
> > From: Rusty Russell <address@hidden>
> >
> > Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p.
> >
> > Signed-off-by: Rusty Russell <address@hidden>
> > Reviewed-by: Anthony Liguori <address@hidden>
> > [ pass VirtIODevice * to memory accessors,
> >   fix missing tswap32 in virtio_scsi_push_event() by Cédric Le Goater,
> >   Greg Kurz <address@hidden> ]
> > Cc: Cédric Le Goater <address@hidden>
> 
> Be careful that, in the meanwhile, two tswap32s's have been added by 
> commit b0b4ea1 (virtio-scsi: add target swap for VirtIOSCSICtrlTMFReq 
> fields, 2014-06-10): one in virtio_scsi_do_tmf, one in 
> virtio_scsi_handle_ctrl.
> 
> Paolo
> 

Yeah I saw these. Thanks.

-- 
Gregory Kurz                                     address@hidden
                                                 address@hidden
Software Engineer @ IBM/Meiosys                  http://www.ibm.com
Tel +33 (0)562 165 496

"Anarchy is about taking complete responsibility for yourself."
        Alan Moore.