[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/16] linux-user: respect timezone for setti
From: |
Paul Burton |
Subject: |
Re: [Qemu-devel] [PATCH v2 08/16] linux-user: respect timezone for settimeofday |
Date: |
Sun, 22 Jun 2014 11:11:04 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sun, Jun 22, 2014 at 12:18:02AM +0100, Peter Maydell wrote:
> > + if (!lock_user_struct(VERIFY_READ, target_tz, target_tz_addr, 1))
> > + return -TARGET_EFAULT;
>
> Coding style mandates braces even on single-line if()s; checkpatch.pl
> will catch this usually.
I copied that style from the equivalent timeval functions, but yeah I'll
make sure to get into the habit of running checkpatch for QEMU patches.
> Code looks OK otherwise.
Thanks for looking,
Paul
signature.asc
Description: Digital signature
- [Qemu-devel] [PATCH v2 00/16] linux-user fixes & improvements, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 02/16] linux-user: support SO_ACCEPTCONN getsockopt option, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 03/16] linux-user: support SO_{SND, RCV}BUFFORCE setsockopt options, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 01/16] linux-user: translate the result of getsockopt SO_TYPE, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 04/16] linux-user: support SO_PASSSEC setsockopt option, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 05/16] linux-user: allow NULL arguments to mount, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 07/16] linux-user: fix struct target_epoll_event layout for MIPS, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 06/16] linux-user: support strace of epoll_create1, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 08/16] linux-user: respect timezone for settimeofday, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 09/16] linux-user: allow NULL tv argument for settimeofday, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 10/16] linux-user: support timerfd_{create, gettime, settime} syscalls, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 11/16] linux-user: support ioprio_{get, set} syscalls, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 12/16] linux-user: support {name_to, open_by}_handle_at syscalls, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 13/16] linux-user: support the setns syscall, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 15/16] linux-user: support the KDSIGACCEPT ioctl, Paul Burton, 2014/06/21
- [Qemu-devel] [PATCH v2 14/16] linux-user: support the unshare syscall, Paul Burton, 2014/06/21