[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 0/4] mirror: Fix behavior for zero byte image
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v3 0/4] mirror: Fix behavior for zero byte image |
Date: |
Tue, 24 Jun 2014 20:26:34 +0800 |
The current behavior of mirroring zero byte image is slightly different from
non-zero image: the BLOCK_JOB_READY event is skipped and job is completed
immediately. This is not a big problem for human user but only makes management
software harder to write. Since we are focusing on an good API instead of UI,
let's make the behavior more consistent and predictable.
The first patch fixes the behavior. The following two patches add test case for
the involved code path.
Thanks for Eric Blake to report this!
v3: Fix test case failure in 4/4. (Kevin)
Add Eric's review-by's in 1~3.
v2: Address Stefan's comments.
- Added patch 01: block_job_yield.
- Use block_job_yield in 02.
- Fix test case updates.
Thanks to Stefan, Paolo and Eric for reviewing!
Fam
Fam Zheng (4):
blockjob: Add block_job_yield()
mirror: Go through ready -> complete process for 0 len image
qemu-iotests: Test BLOCK_JOB_READY event for 0Kb image active commit
qemu-iotests: Test 0-length image for mirror
block/mirror.c | 11 ++++++++++-
blockjob.c | 14 ++++++++++++++
include/block/blockjob.h | 8 ++++++++
tests/qemu-iotests/040 | 12 +++++++++---
tests/qemu-iotests/040.out | 4 ++--
tests/qemu-iotests/041 | 11 ++++++++---
tests/qemu-iotests/041.out | 4 ++--
7 files changed, 53 insertions(+), 11 deletions(-)
--
2.0.0
- [Qemu-devel] [PATCH v3 0/4] mirror: Fix behavior for zero byte image,
Fam Zheng <=
- [Qemu-devel] [PATCH v3 1/4] blockjob: Add block_job_yield(), Fam Zheng, 2014/06/24
- [Qemu-devel] [PATCH v3 2/4] mirror: Go through ready -> complete process for 0 len image, Fam Zheng, 2014/06/24
- [Qemu-devel] [PATCH v3 3/4] qemu-iotests: Test BLOCK_JOB_READY event for 0Kb image active commit, Fam Zheng, 2014/06/24
- [Qemu-devel] [PATCH v3 4/4] qemu-iotests: Test 0-length image for mirror, Fam Zheng, 2014/06/24
- Re: [Qemu-devel] [PATCH v3 0/4] mirror: Fix behavior for zero byte image, Kevin Wolf, 2014/06/24