Re: [Qemu-devel] [PATCH 4/4] [RFC] Eliminate PC-specific compat_props

[Eduardo Habkost]

On Tue, Jun 24, 2014 at 10:51:39PM +0300, Marcel Apfelbaum wrote:
> On Tue, 2014-06-24 at 15:02 -0300, Eduardo Habkost wrote:
> > All compat properties are only applied if a device of an specific type
> > is instantiated. There's no need to keep a PC-specific list of compat
> > properties, as properties for PC-specific devices won't affect other
> > machine-types anyway.
> 
> So why do we still need 2 sets of hierarchies PC_I440FX_COMPAT_x_y and
> PC_Q35_COMPAT_x_y? It seems that QEMU_COMPAT_x_y is enough.
> Am I missing something?


A single PC_COMPAT_* hierarchy should be enough after this patch, yes. I
left them there because I was not sure this RFC would be accepted, and
wanted to keep the changes simple.

If people are OK with this patch, I can reorder the changes in this
series and move everything to QEMU_COMPAT_* in fewer steps, without even
creating the new PC_I440FX_COMPAT_* macros.

-- 
Eduardo