Re: [Qemu-devel] [v5][PATCH 2/5] xen, gfx passthrough: create pseudo intel isa bridge

[Chen, Tiejun]

On 2014/6/25 14:22, Paolo Bonzini wrote:
> Il 25/06/2014 04:17, Tiejun Chen ha scritto:
> > +static int create_pseudo_pch_isa_bridge(PCIBus *bus, XenHostPCIDevice
> > *hdev)
> > +{
> > +    struct PCIDevice *dev;
> > +
> > +    char rid;
> > +
> > +    /* We havt to use a simple PCI device to fake this ISA bridge
> > +     * to avoid making some confusion to BIOS and ACPI.
> > +     */
> > +    dev = pci_create(bus, PCI_DEVFN(0x1f, 0),
> > "pseudo-intel-pch-isa-bridge");
> > +
> > +    qdev_init_nofail(&dev->qdev);
> > +
> > +    pci_config_set_vendor_id(dev->config, hdev->vendor_id);
> > +    pci_config_set_device_id(dev->config, hdev->device_id);
> > +
> > +    xen_host_pci_get_block(hdev, PCI_REVISION_ID, (uint8_t *)&rid, 1);
> > +
> > +    pci_config_set_revision(dev->config, rid);
> > +
> > +    XEN_PT_LOG(dev, "The pseudo Intel PCH ISA bridge created.\n");
> > +    return 0;
> > +}
>
> This patch doesn't compile on its own (this static function is unused).
>
> pci_create_pch should be moved in this patch.

Okay I will try this.

Thanks
Tiejun