qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 6/9] block: Inline bdrv_file_open()


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 6/9] block: Inline bdrv_file_open()
Date: Wed, 25 Jun 2014 09:49:14 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

On 06/25/2014 08:35 AM, Kevin Wolf wrote:
> It doesn't do much any more, we can move the code to bdrv_open() now.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Benoit Canet <address@hidden>
> ---
>  block.c | 51 +++++++++++----------------------------------------
>  1 file changed, 11 insertions(+), 40 deletions(-)
> 

>          if (!ret) {
> +            bs->growable = 1;

Is it worth converting bs->growable to bool at some point in this
series?  But saving it for a separate patch is wise, so:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]