qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines


From: Hu Tao
Subject: Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines
Date: Fri, 27 Jun 2014 11:41:05 +0800
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Jun 26, 2014 at 05:52:45AM -0600, Eric Blake wrote:
> On 06/26/2014 12:13 AM, Hu Tao wrote:
> > We already have ROUND_UP but there are similar macros and ROUND_UP-like
> > lines all around, replace them with ROUND_UP and clean up similar macros.
> 
> Not a review (yet), but a question - how did you find lines to convert?
> Is there a particular grep pattern you looked for, or a Coccinelle
> script, or ...? I ask because it would be nice information in the commit
> message, so that the actual review can also look to see if you missed
> any instances that could use the conversion.

Good point. I used grep but indeed I've missed some instances.

Regards,
Hu



reply via email to

[Prev in Thread] Current Thread [Next in Thread]