[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 2.1 0/2] Fix commit of oversized layer
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH for 2.1 0/2] Fix commit of oversized layer |
Date: |
Fri, 27 Jun 2014 11:44:49 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 25.06.2014 um 22:55 hat Jeff Cody geschrieben:
> This fixes a regression in block-commit; if the top image is larger than the
> base image, we attempt to resize the base image. The regression is that we
> fail the image truncate operation, returning -EBUSY.
Thanks, applied to the block branch.
One thing I'm not sure about is whether commit (all of synchronous,
live and live on active layer) should check the RESIZE blocker before
resizing the backing file.
In general, it feels like it would be the right thing to do, especially
considering the goal of operation categories in the final state, but on
the other hand it means that RESIZE would have to be excluded from
bs->backing_blocker, too, allowing standalone resize commands on backing
files. Not sure that this would be a good idea...
Kevin