Re: [Qemu-devel] [PATCH v2 00/16] linux-user fixes & improvements

[Riku Voipio]

On Sat, Jun 21, 2014 at 11:52:55PM +0100, Paul Burton wrote:
> From: Paul Burton <address@hidden>
> 
> This series fixes a number of bugs in QEMUs linux-user support, some
> specific to targetting the MIPS architecture but mostly generic. It also
> adds support for some previously unsupported syscalls & {g,s}etsockopt
> options.

Looks mostly good - unfortunately I missed some issues last round. 
iI gave comments to the {name_to,open_by}_handle_at patch - which also
caused the build error for Peter.

Also, compile test on older distro showed that new syscalls need both
target and host test:

#ifdef TARGET_NR_setns

needs to be replaced with

#if defined(TARGET_NR_setns) && defined(__NR_setns) 

Riku

> Paul Burton (16):
>   linux-user: translate the result of getsockopt SO_TYPE
>   linux-user: support SO_ACCEPTCONN getsockopt option
>   linux-user: support SO_{SND,RCV}BUFFORCE setsockopt options
>   linux-user: support SO_PASSSEC setsockopt option
>   linux-user: allow NULL arguments to mount
>   linux-user: support strace of epoll_create1
>   linux-user: fix struct target_epoll_event layout for MIPS
>   linux-user: respect timezone for settimeofday
>   linux-user: allow NULL tv argument for settimeofday
>   linux-user: support timerfd_{create,gettime,settime} syscalls
>   linux-user: support ioprio_{get,set} syscalls
>   linux-user: support {name_to,open_by}_handle_at syscalls
>   linux-user: support the setns syscall
>   linux-user: support the unshare syscall
>   linux-user: support the KDSIGACCEPT ioctl
>   linux-user: support the SIOCGIFINDEX ioctl
> 
>  linux-user/ioctls.h       |   2 +
>  linux-user/socket.h       |   5 +
>  linux-user/strace.c       |  30 +++++
>  linux-user/strace.list    |  21 ++++
>  linux-user/syscall.c      | 271 
> +++++++++++++++++++++++++++++++++++++++++-----
>  linux-user/syscall_defs.h |   9 +-
>  6 files changed, 311 insertions(+), 27 deletions(-)
> 
> -- 
> 2.0.0