[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/5] nbd: Don't export a block device with no medium.
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 1/5] nbd: Don't export a block device with no medium. |
Date: |
Fri, 27 Jun 2014 16:11:42 +0200 |
From: Hani Benhabiles <address@hidden>
The device is exported with erroneous values and can't be read.
Before the patch:
$ sudo nbd-client localhost -p 10809 /dev/nbd0 -name floppy0
Negotiation: ..size = 17592186044415MB
bs=1024, sz=18446744073709547520 bytes
$ sudo mount /dev/nbd0 /mnt/tmp/
mount: block device /dev/nbd0 is write-protected, mounting read-only
mount: /dev/nbd0: can't read superblock
After the patch:
(qemu) nbd_server_add ide0-hd0
(qemu) nbd_server_add floppy0
Device 'floppy0' has no medium
Signed-off-by: Hani Benhabiles <address@hidden>
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>
---
blockdev-nbd.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/blockdev-nbd.c b/blockdev-nbd.c
index b60b66d..18dc528 100644
--- a/blockdev-nbd.c
+++ b/blockdev-nbd.c
@@ -91,6 +91,10 @@ void qmp_nbd_server_add(const char *device, bool
has_writable, bool writable,
error_set(errp, QERR_DEVICE_NOT_FOUND, device);
return;
}
+ if (!bdrv_is_inserted(bs)) {
+ error_set(errp, QERR_DEVICE_HAS_NO_MEDIUM, device);
+ return;
+ }
if (!has_writable) {
writable = false;
--
1.8.3.1
- [Qemu-devel] [PULL 0/5] NBD changes for 2014-06-27, Paolo Bonzini, 2014/06/27
- [Qemu-devel] [PULL 1/5] nbd: Don't export a block device with no medium.,
Paolo Bonzini <=
- [Qemu-devel] [PULL 2/5] nbd: Don't validate from and len in NBD_CMD_DISC., Paolo Bonzini, 2014/06/27
- [Qemu-devel] [PULL 4/5] nbd: Handle fixed new-style clients., Paolo Bonzini, 2014/06/27
- [Qemu-devel] [PULL 3/5] nbd: Shutdown socket before closing., Paolo Bonzini, 2014/06/27
- [Qemu-devel] [PULL 5/5] nbd: Handle NBD_OPT_LIST option., Paolo Bonzini, 2014/06/27
- Re: [Qemu-devel] [PULL 0/5] NBD changes for 2014-06-27, Peter Maydell, 2014/06/29