[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/4] qemu-bridge-helper: Fix fd leak in main()
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 1/4] qemu-bridge-helper: Fix fd leak in main() |
Date: |
Fri, 27 Jun 2014 16:24:50 +0200 |
From: Gonglei <address@hidden>
initialize fd and ctlfd, and close them at the end
Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
qemu-bridge-helper.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c
index 6a0974e..36eb3bc 100644
--- a/qemu-bridge-helper.c
+++ b/qemu-bridge-helper.c
@@ -229,7 +229,7 @@ int main(int argc, char **argv)
unsigned long ifargs[4];
#endif
int ifindex;
- int fd, ctlfd, unixfd = -1;
+ int fd = -1, ctlfd = -1, unixfd = -1;
int use_vnet = 0;
int mtu;
const char *bridge = NULL;
@@ -436,7 +436,12 @@ int main(int argc, char **argv)
/* profit! */
cleanup:
-
+ if (fd >= 0) {
+ close(fd);
+ }
+ if (ctlfd >= 0) {
+ close(ctlfd);
+ }
while ((acl_rule = QSIMPLEQ_FIRST(&acl_list)) != NULL) {
QSIMPLEQ_REMOVE_HEAD(&acl_list, entry);
g_free(acl_rule);
--
1.9.3