Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind

[Gerd Hoffmann]

  Hi,

> >  * The old qemu_chr_open_socket() has an
> >    "if (!is_waitconnect)
> >        qemu_set_nonblock(fd);
> >    which the QMP char-open codepath has never had. Does this matter?
> >    Which of the two code paths was correct?
> 
> Gerd?

IIRC the socket is put into non-blocking mode anyway by the qemu socket
helper functions.

cheers,
  Gerd