|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 0/3] block: introduce submit I/O at batch |
Date: | Mon, 30 Jun 2014 14:32:07 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
Il 30/06/2014 14:16, Ming Lei ha scritto:
I added the io queue into AioContext because the io queue can only be used in the attached context(or thread), that said the io queue has to be put into per context instance.
It doesn't *have* to be per-thread.It is certainly simplest if you make it per-io_context_t, but this in the current code means making it per-BlockDriverState and putting it in block/linux-aio.c.
OK, I will not consider backing_hd case in v1, also the patchset will not only improve dataplane, and other devices should benefit from it too. These patches themselves should be simple, and most of code are add-only, if bdrv_io_plug()/bdrv_io_unplug() isn't used, they are very close to noop. I just wrote a draft patch to apply the mechanism on virtio-scsi, and the improvement is obvious.
I certainly agree. However, we have to also consider that we're close to releasing 2.1.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |