Re: [Qemu-devel] [PATCH v2 0/5] bootdevice: Refactor and improvement

[Markus Armbruster]

<address@hidden> writes:

> From: Gonglei <address@hidden>
>
> Changes of v2:
>  Thanks to Peter's report and suggestion.
>  - fix 'make check' complaint.
>  - fix inapposite using &error_abort in patch 5.
>
> Because of Peter's review comments in a pull request, I start a new
> round review about this patch series v2. Please review, Thanks.
>
> Patch 1 just move boot order related code to bootdevice.c.
> Patch 2,3,5 add an argument to corresponding functions.
> This way, we can propagate the error messages to the caller.
> Maybe somebody will say we will remove the legacy boot order
> in the future, instead of using bootindex. But at present,
> for PPC, the have no way support bootindex, ARM on the flight
> (Laszlo Ersek) as far as know.
>
> After this work, we can easily to add QMP command for existing
> HMP command 'boot_set' if we have a requirement.

I don't understand why you move declarations to sysemu.h, and I had a
few remarks here and there.  But I couldn't see anything wrong, so:

Series
Reviewed-by: Markus Armbruster <address@hidden>