[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 08/15] spapr: create DR connectors for PHBs
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH 08/15] spapr: create DR connectors for PHBs and register reset hooks |
Date: |
Thu, 30 Apr 2015 16:08:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 29/04/2015 21:20, Michael Roth wrote:
> + if (spapr->dr_phb_enabled) {
> + for (i = 0; i < SPAPR_DRC_MAX_PHB; i++) {
> + sPAPRDRConnector *drc =
> + spapr_dr_connector_new(OBJECT(machine),
> + SPAPR_DR_CONNECTOR_TYPE_PHB, i);
> + qemu_register_reset(spapr_drc_reset, drc);
> + }
> + }
Is this needed because drc is busless? Then I think it should be done
in device_set_realized (and the matching qemu_unregister_reset too).
Paolo
- Re: [Qemu-devel] [RFC PATCH 04/15] spapr_iommu: pass object ownership to parent/owner, (continued)
- [Qemu-devel] [RFC PATCH 15/15] spapr: add hotplug hooks for PHB hotplug, Michael Roth, 2015/04/29
- [Qemu-devel] [RFC PATCH 03/15] spapr_drc: pass object ownership to parent/owner, Michael Roth, 2015/04/29
- [Qemu-devel] [RFC PATCH 05/15] spapr_pci: add PHB unrealize, Michael Roth, 2015/04/29
- [Qemu-devel] [RFC PATCH 07/15] spapr: enable PHB hotplug for pseries-2.4, Michael Roth, 2015/04/29
- [Qemu-devel] [RFC PATCH 06/15] spapr_pci: also use 'index' property as DRC index for PHBs, Michael Roth, 2015/04/29
- [Qemu-devel] [RFC PATCH 08/15] spapr: create DR connectors for PHBs and register reset hooks, Michael Roth, 2015/04/29
- Re: [Qemu-devel] [RFC PATCH 08/15] spapr: create DR connectors for PHBs and register reset hooks,
Paolo Bonzini <=
- Re: [Qemu-devel] [RFC PATCH 00/15] spapr: add support for PHB hotplug, Paolo Bonzini, 2015/04/30