[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Ping: [PATCH] xen/pass-through: fold host PCI command regis
From: |
Jan Beulich |
Subject: |
[Qemu-devel] Ping: [PATCH] xen/pass-through: fold host PCI command register writes |
Date: |
Mon, 01 Jun 2015 07:55:27 +0100 |
Ping?
>>> On 15.05.15 at 14:46, <address@hidden> wrote:
> The code introduced to address XSA-126 allows simplification of other
> code in xen_pt_initfn(): All we need to do is update "cmd" suitably,
> as it'll be written back to the host register near the end of the
> function anyway.
>
> Signed-off-by: Jan Beulich <address@hidden>
>
> --- a/hw/xen/xen_pt.c
> +++ b/hw/xen/xen_pt.c
> @@ -698,10 +698,7 @@ static int xen_pt_initfn(PCIDevice *d)
> machine_irq, pirq, rc);
>
> /* Disable PCI intx assertion (turn on bit10 of devctl) */
> - xen_host_pci_set_word(&s->real_device,
> - PCI_COMMAND,
> - pci_get_word(s->dev.config + PCI_COMMAND)
> - | PCI_COMMAND_INTX_DISABLE);
> + cmd |= PCI_COMMAND_INTX_DISABLE;
> machine_irq = 0;
> s->machine_irq = 0;
> } else {
> @@ -723,9 +720,7 @@ static int xen_pt_initfn(PCIDevice *d)
> e_intx, rc);
>
> /* Disable PCI intx assertion (turn on bit10 of devctl) */
> - xen_host_pci_set_word(&s->real_device, PCI_COMMAND,
> - *(uint16_t *)(&s->dev.config[PCI_COMMAND])
> - | PCI_COMMAND_INTX_DISABLE);
> + cmd |= PCI_COMMAND_INTX_DISABLE;
> xen_pt_mapped_machine_irq[machine_irq]--;
>
> if (xen_pt_mapped_machine_irq[machine_irq] == 0) {
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> address@hidden
> http://lists.xen.org/xen-devel
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] Ping: [PATCH] xen/pass-through: fold host PCI command register writes,
Jan Beulich <=