Re: [Qemu-devel] [PATCH] tcg: Mask TCGMemOp appropriately for indexing

[Yongbok Kim]

On 29/05/2015 18:35, Richard Henderson wrote:
> The addition of MO_AMASK means that places that used inverted masks
> need to be changed to use positive masks, and places that failed to
> mask the intended bits need updating.
> 
> Cc: Yongbok Kim <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> 
> This should fix the problem you found while testing the mipsr6
> unaligned memory ops patch set.
> 
> 
> r~

I have noticed that you haven't changed it for the tci, is it deliberate?
Another minor thing is that tcg_dump_ops() in tcg.c wouldn't print ld/st
names correctly but hex code will be printed out.

Otherwise,
Reviewed-by: Yongbok Kim <address@hidden>

Regards,
Yongbok