[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 04/13] blockdev: Lock BDS during external snapsho
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v2 04/13] blockdev: Lock BDS during external snapshot transaction |
Date: |
Tue, 2 Jun 2015 11:21:53 +0800 |
Lock immediately follows aio_context_acquire, so unlock right before
the corresponding aio_context_release.
Signed-off-by: Fam Zheng <address@hidden>
---
blockdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index fdc5a17..a8d5b10 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1471,6 +1471,7 @@ static void external_snapshot_prepare(BlkTransactionState
*common,
/* Acquire AioContext now so any threads operating on old_bs stop */
state->aio_context = bdrv_get_aio_context(state->old_bs);
aio_context_acquire(state->aio_context);
+ bdrv_lock(state->old_bs);
if (!bdrv_is_inserted(state->old_bs)) {
error_set(errp, QERR_DEVICE_HAS_NO_MEDIUM, device);
@@ -1540,6 +1541,7 @@ static void external_snapshot_commit(BlkTransactionState
*common)
bdrv_reopen(state->new_bs, state->new_bs->open_flags & ~BDRV_O_RDWR,
NULL);
+ bdrv_unlock(state->old_bs);
aio_context_release(state->aio_context);
}
@@ -1551,6 +1553,7 @@ static void external_snapshot_abort(BlkTransactionState
*common)
bdrv_unref(state->new_bs);
}
if (state->aio_context) {
+ bdrv_unlock(state->old_bs);
aio_context_release(state->aio_context);
}
}
--
2.4.1
- [Qemu-devel] [PATCH v2 00/13] block: Protect block jobs with lock / unlock API, Fam Zheng, 2015/06/01
- [Qemu-devel] [PATCH v2 03/13] blockdev: Lock BDS during internal snapshot transaction, Fam Zheng, 2015/06/01
- [Qemu-devel] [PATCH v2 04/13] blockdev: Lock BDS during external snapshot transaction,
Fam Zheng <=
- [Qemu-devel] [PATCH v2 05/13] blockdev: Lock BDS during drive-backup transaction, Fam Zheng, 2015/06/01
- [Qemu-devel] [PATCH v2 06/13] blockdev: Lock BDS during blockdev-backup transaction, Fam Zheng, 2015/06/01
- [Qemu-devel] [PATCH v2 07/13] mirror: Protect source between bdrv_drain and bdrv_swap, Fam Zheng, 2015/06/01
- [Qemu-devel] [PATCH v2 08/13] block: Add bdrv_add_lock_unlock_notifier, Fam Zheng, 2015/06/01
- [Qemu-devel] [PATCH v2 09/13] block-backend: Add blk_add_lock_unlock_notifier, Fam Zheng, 2015/06/01
- [Qemu-devel] [PATCH v2 10/13] virtio-blk: Move complete_request to 'ops' structure, Fam Zheng, 2015/06/01
- [Qemu-devel] [PATCH v2 11/13] virtio-blk: Don't handle output when backend is locked, Fam Zheng, 2015/06/01
- [Qemu-devel] [PATCH v2 12/13] virtio-scsi-dataplane: Add backend lock listener, Fam Zheng, 2015/06/01
- [Qemu-devel] [PATCH v2 13/13] nbd-server: Clear "can_read" when backend is locked, Fam Zheng, 2015/06/01