[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 18/21] monitor: Drop do_qmp_capabilities()'s superflu
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 18/21] monitor: Drop do_qmp_capabilities()'s superfluous QMP check |
Date: |
Tue, 2 Jun 2015 10:23:56 +0200 |
Superfluous since commit 30f5041 removed it from HMP.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Luiz Capitulino <address@hidden>
---
monitor.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/monitor.c b/monitor.c
index f20e918..daba98f 100644
--- a/monitor.c
+++ b/monitor.c
@@ -566,11 +566,7 @@ static void monitor_qapi_event_init(void)
static int do_qmp_capabilities(Monitor *mon, const QDict *params,
QObject **ret_data)
{
- /* Will setup QMP capabilities in the future */
- if (monitor_ctrl_mode(mon)) {
- mon->qmp.command_mode = 1;
- }
-
+ mon->qmp.command_mode = 1;
return 0;
}
--
1.9.3
- [Qemu-devel] [PULL 07/21] monitor: Use trad. command interface for HMP pcie_aer_inject_error, (continued)
- [Qemu-devel] [PULL 07/21] monitor: Use trad. command interface for HMP pcie_aer_inject_error, Markus Armbruster, 2015/06/02
- [Qemu-devel] [PULL 03/21] monitor: Improve and document client_migrate_info protocol error, Markus Armbruster, 2015/06/02
- [Qemu-devel] [PULL 04/21] monitor: Convert client_migrate_info to QAPI, Markus Armbruster, 2015/06/02
- [Qemu-devel] [PULL 01/21] monitor: Drop broken, unused asynchronous command interface, Markus Armbruster, 2015/06/02
- [Qemu-devel] [PULL 13/21] monitor: Inline monitor_has_error() into its only caller, Markus Armbruster, 2015/06/02
- [Qemu-devel] [PULL 20/21] monitor: Rename monitor_ctrl_mode() to monitor_is_qmp(), Markus Armbruster, 2015/06/02
- [Qemu-devel] [PULL 21/21] monitor: Change return type of monitor_cur_is_qmp() to bool, Markus Armbruster, 2015/06/02
- [Qemu-devel] [PULL 10/21] monitor: Propagate errors through qmp_check_input_obj(), Markus Armbruster, 2015/06/02
- [Qemu-devel] [PULL 16/21] monitor: Rename monitor_control_read(), monitor_control_event(), Markus Armbruster, 2015/06/02
- [Qemu-devel] [PULL 15/21] monitor: Rename handle_user_command() to handle_hmp_command(), Markus Armbruster, 2015/06/02
- [Qemu-devel] [PULL 18/21] monitor: Drop do_qmp_capabilities()'s superfluous QMP check,
Markus Armbruster <=
- [Qemu-devel] [PULL 19/21] monitor: Turn int command_mode into bool in_command_mode, Markus Armbruster, 2015/06/02
- [Qemu-devel] [PULL 17/21] monitor: Unbox Monitor member mc and rename to qmp, Markus Armbruster, 2015/06/02
- [Qemu-devel] [PULL 14/21] monitor: Limit QError use to command handlers, Markus Armbruster, 2015/06/02
- Re: [Qemu-devel] [PULL 00/21] Monitor patches, Peter Maydell, 2015/06/04