Re: [Qemu-devel] [PATCH 3/9] vl: Fail right after first bad -object

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 05/28/2015 06:21 AM, Markus Armbruster wrote:
>> Failure to create a -object is a fatal error.  However, we delay the
>
> s/a -object/an -object/ ? (depends on whether you pronounce '-object' as
> "object" or "dash-object")

I'll use "to create an object with -object".

>> actual exit until all -object are processed.  On the one hand, this
>> permits detection of genuine additional errors.  On the other hand, it
>> can muddy the waters with uninteresting additional errors, e.g. when a
>> later -object tries to reference a prior one that failed.
>> 
>> We generally stop right on the first bad option, so do that for
>> -object as well.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  vl.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <address@hidden>

Thanks!