[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/4] qmp/hmp: add rocker device support
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/4] qmp/hmp: add rocker device support |
Date: |
Tue, 2 Jun 2015 16:07:06 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, May 29, 2015 at 07:01:49AM -0700, address@hidden wrote:
> +void hmp_rocker_of_dpa_flows(Monitor *mon, const QDict *qdict)
> +{
> + RockerOfDpaFlowList *list, *info;
> + const char *name = qdict_get_str(qdict, "name");
> + uint32_t tbl_id = qdict_get_try_int(qdict, "tbl_id", -1);
> + Error *errp = NULL;
> +
> + list = qmp_query_rocker_of_dpa_flows(name, tbl_id != -1, tbl_id, &errp);
> + if (errp != NULL) {
> + hmp_handle_error(mon, &errp);
> + return;
> + }
> +
> + monitor_printf(mon, "prio tbl hits key(mask) --> actions\n");
> +
> + for (info = list; info; info = info->next) {
> + RockerOfDpaFlow *flow = info->value;
> + RockerOfDpaFlowKey *key = flow->key;
> + RockerOfDpaFlowMask *mask = flow->mask;
> + RockerOfDpaFlowAction *action = flow->action;
> +
> + if (flow->hits) {
> + monitor_printf(mon, "%-4d %-3d %-4ld",
> + key->priority, key->tbl_id, flow->hits);
flow->hits is uint64_t so I changed the format string to use %-4" PRIu64
when merging the patches. This way it compiles cleanly on 32-bit hosts.
pgp49IKRLTzwc.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH v3 4/4] qmp/hmp: add rocker device support,
Stefan Hajnoczi <=