[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/10 v11] target-tilegx: Add cpu basic features
From: |
Chen Gang |
Subject: |
Re: [Qemu-devel] [PATCH 07/10 v11] target-tilegx: Add cpu basic features for linux-user |
Date: |
Wed, 3 Jun 2015 04:47:40 +0800 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
Firstly, thank you very much for your valuable work for all patches.
On 6/3/15 01:51, Peter Maydell wrote:
> On 30 May 2015 at 22:15, Chen Gang <address@hidden> wrote:
>> +
>> +#define TILEGX_IS_ERRNO(ret) \
>> + ((ret) > 0xfffffffffffff000ULL) /* errno is 0 --
>> 4096 */
>
> TILEGX_IS_ERRNO is specific to the Linux syscall ABI; it
> belongs in linux-user/ somewhere, not here.
>
OK, thanks. I shall move it to linux-user/tilegx/syscall.h.
>> +#define ENV_GET_CPU(e) CPU(tilegx_env_get_cpu(e))
>> +
>> +#define ENV_OFFSET offsetof(TileGXCPU, env)
>> +
>> +/* TILE-Gx memory attributes */
>> +#define TARGET_PAGE_BITS 16 /* TILE-Gx uses 64KB page size */
>> +#define MMAP_SHIFT TARGET_PAGE_BITS
>
> MMAP_SHIFT is linux ABI specific and doesn't belong in this file.
>
OK, thanks. I shall move it to linux-user/tilegx/syscall.h (although
all the other targets still put it in "target-*/cpu.h").
>> +#define TARGET_PHYS_ADDR_SPACE_BITS 42 /* It has 42 bit physical addresses
>> */
>> +#define TARGET_VIRT_ADDR_SPACE_BITS 64 /* It has 64 bit virtual addresses */
>
> These comments are stating the obvious and can be deleted.
>
OK, thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed