[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/8] qemu-iotests: expand test 093 to support gr
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 8/8] qemu-iotests: expand test 093 to support group throttling |
Date: |
Wed, 3 Jun 2015 11:32:58 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, May 29, 2015 at 03:29:57PM +0200, Alberto Garcia wrote:
> On Fri 29 May 2015 02:32:45 PM CEST, Stefan Hajnoczi <address@hidden> wrote:
>
> >> def setUp(self):
> >> - self.vm = iotests.VM().add_drive(self.test_img)
> >> + self.vm = iotests.VM()
> >> + for i in range(0, self.max_drives):
> >> + self.vm.add_drive(self.test_img)
> >
> > Unique files are required, it's not safe to write to open the same
> > image file for writing multiple times.
>
> But there's no file here, self.test_img is null-aio://
You are right. ThrottleTestCase is only used in this file so there's
little danger of setUp() getting called with actual files.
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgppsRnQlNG5a.pgp
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 8/8] qemu-iotests: expand test 093 to support group throttling,
Stefan Hajnoczi <=