[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 09/10] qcow2: Point to amend function in check
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v8 09/10] qcow2: Point to amend function in check |
Date: |
Wed, 3 Jun 2015 22:13:38 +0200 |
If a reference count is not representable with the current refcount
order, the image check should point to qemu-img amend for increasing the
refcount order. However, qemu-img amend needs write access to the image
which cannot be provided if the image is marked corrupt; and the image
check will not mark the image consistent unless everything actually is
consistent.
Therefore, if an image is marked corrupt and the image check encounters
a reference count overflow, it cannot be fixed by using qemu-img amend
to increase the refcount order. Instead, one has to use qemu-img convert
to create a completely new copy of the image in this case.
Alternatively, we may want to give the user a way of manually removing
the corrupt flag, maybe through qemu-img amend, but this is not part of
this patch.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
---
block/qcow2-refcount.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 13397a9..38091c6 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -1328,6 +1328,9 @@ static int inc_refcounts(BlockDriverState *bs,
if (refcount == s->refcount_max) {
fprintf(stderr, "ERROR: overflow cluster offset=0x%" PRIx64
"\n", cluster_offset);
+ fprintf(stderr, "Use qemu-img amend to increase the refcount entry
"
+ "width or qemu-img convert to create a clean copy if the "
+ "image cannot be opened for writing\n");
res->corruptions++;
continue;
}
--
2.4.1
- [Qemu-devel] [PATCH v8 03/10] qcow2: Use error_report() in qcow2_amend_options(), (continued)
- [Qemu-devel] [PATCH v8 03/10] qcow2: Use error_report() in qcow2_amend_options(), Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v8 02/10] block: Add opaque value to the amend CB, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v8 05/10] qcow2: Split upgrade/downgrade paths for amend, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v8 06/10] qcow2: Use intermediate helper CB for amend, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v8 07/10] qcow2: Add function for refcount order amendment, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v8 08/10] qcow2: Invoke refcount order amendment function, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v8 09/10] qcow2: Point to amend function in check,
Max Reitz <=
- [Qemu-devel] [PATCH v8 10/10] iotests: Extend test 112 for qemu-img amend, Max Reitz, 2015/06/03