[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 08/38] block: Invoke change media CB before N
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 08/38] block: Invoke change media CB before NULLing drv |
Date: |
Wed, 03 Jun 2015 14:25:54 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/03/2015 01:43 PM, Max Reitz wrote:
> In order to handle host device passthrough, some guest device models
> may call blk_is_inserted() to check whether the medium is inserted on
> the host, when checking the guest tray status.
>
> This tray status is inquired by blk_dev_change_media_cb(); because
> bdrv_is_inserted() (invoked by blk_is_inserted()) always returns 0 for
> BDS with drv set to NULL, blk_dev_change_media_cb() should therefore be
> called before drv is set to NULL.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 03/38] iotests: Only create BB if necessary, (continued)
- [Qemu-devel] [PATCH v3 03/38] iotests: Only create BB if necessary, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 05/38] block: Add blk_is_available(), Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 04/38] block: Make bdrv_is_inserted() return a bool, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 06/38] block: Make bdrv_is_inserted() recursive, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 08/38] block: Invoke change media CB before NULLing drv, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 07/38] block/quorum: Implement bdrv_is_inserted(), Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 10/38] hw/usb-storage: Check whether BB is inserted, Max Reitz, 2015/06/03