[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 14/38] block: Move BlockAcctStats into BlockB
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 14/38] block: Move BlockAcctStats into BlockBackend |
Date: |
Wed, 03 Jun 2015 14:52:34 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/03/2015 01:43 PM, Max Reitz wrote:
> As the comment above bdrv_get_stats() says, BlockAcctStats is something
> which belongs to the device instead of each BlockDriverState. This patch
> therefore moves it into the BlockBackend.
Again, Berto may want to eventually report stats for both BDS and BB,
but that can come later. For now, this is reasonable refactoring.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block.c | 11 -----------
> block/block-backend.c | 5 ++++-
> block/io.c | 6 +++++-
> block/qapi.c | 24 ++++++++++++++----------
> include/block/block.h | 2 --
> include/block/block_int.h | 3 ---
> 6 files changed, 23 insertions(+), 28 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v3 09/38] hw/block/fdc: Implement tray status, (continued)
- [Qemu-devel] [PATCH v3 11/38] block: Fix BB AIOCB AioContext without BDS, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 12/38] block: Move guest_block_size into BlockBackend, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 13/38] block: Remove wr_highest_sector from BlockAcctStats, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 14/38] block: Move BlockAcctStats into BlockBackend, Max Reitz, 2015/06/03
- Re: [Qemu-devel] [PATCH v3 14/38] block: Move BlockAcctStats into BlockBackend,
Eric Blake <=
- Re: [Qemu-devel] [Qemu-block] [PATCH v3 14/38] block: Move BlockAcctStats into BlockBackend, Alberto Garcia, 2015/06/05
- [Qemu-devel] [PATCH v3 16/38] block: Add BlockBackendRootState, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 15/38] block: Move I/O status and error actions into BB, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 17/38] block: Make some BB functions fall back to BBRS, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 18/38] block: Fail requests to empty BlockBackend, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 20/38] block: Add blk_insert_bs(), Max Reitz, 2015/06/03