[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 09/13] alsaaudio: Remove unused error handling of
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v4 09/13] alsaaudio: Remove unused error handling of qemu_set_fd_handler |
Date: |
Thu, 4 Jun 2015 14:45:20 +0800 |
The function cannot fail, so the check is superfluous.
Signed-off-by: Fam Zheng <address@hidden>
---
audio/alsaaudio.c | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
index 74ead97..ed7655d 100644
--- a/audio/alsaaudio.c
+++ b/audio/alsaaudio.c
@@ -266,31 +266,19 @@ static int alsa_poll_helper (snd_pcm_t *handle, struct
pollhlp *hlp, int mask)
for (i = 0; i < count; ++i) {
if (pfds[i].events & POLLIN) {
- err = qemu_set_fd_handler (pfds[i].fd, alsa_poll_handler,
- NULL, hlp);
+ qemu_set_fd_handler (pfds[i].fd, alsa_poll_handler, NULL, hlp);
}
if (pfds[i].events & POLLOUT) {
if (conf.verbose) {
dolog ("POLLOUT %d %d\n", i, pfds[i].fd);
}
- err = qemu_set_fd_handler (pfds[i].fd, NULL,
- alsa_poll_handler, hlp);
+ qemu_set_fd_handler (pfds[i].fd, NULL, alsa_poll_handler, hlp);
}
if (conf.verbose) {
dolog ("Set handler events=%#x index=%d fd=%d err=%d\n",
pfds[i].events, i, pfds[i].fd, err);
}
- if (err) {
- dolog ("Failed to set handler events=%#x index=%d fd=%d err=%d\n",
- pfds[i].events, i, pfds[i].fd, err);
-
- while (i--) {
- qemu_set_fd_handler (pfds[i].fd, NULL, NULL, NULL);
- }
- g_free (pfds);
- return -1;
- }
}
hlp->pfds = pfds;
hlp->count = count;
--
2.4.2
- [Qemu-devel] [PATCH v4 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2, Fam Zheng, 2015/06/04
- [Qemu-devel] [PATCH v4 01/13] stubs: Add qemu_set_fd_handler, Fam Zheng, 2015/06/04
- [Qemu-devel] [PATCH v4 02/13] qemu-nbd: Switch to qemu_set_fd_handler, Fam Zheng, 2015/06/04
- [Qemu-devel] [PATCH v4 03/13] l2tpv3: Drop l2tpv3_can_send, Fam Zheng, 2015/06/04
- [Qemu-devel] [PATCH v4 04/13] netmap: Drop netmap_can_send, Fam Zheng, 2015/06/04
- [Qemu-devel] [PATCH v4 05/13] net/socket: Drop net_socket_can_send, Fam Zheng, 2015/06/04
- [Qemu-devel] [PATCH v4 06/13] tap: Drop tap_can_send, Fam Zheng, 2015/06/04
- [Qemu-devel] [PATCH v4 07/13] Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler, Fam Zheng, 2015/06/04
- [Qemu-devel] [PATCH v4 08/13] main-loop: Drop qemu_set_fd_handler2, Fam Zheng, 2015/06/04
- [Qemu-devel] [PATCH v4 09/13] alsaaudio: Remove unused error handling of qemu_set_fd_handler,
Fam Zheng <=
- [Qemu-devel] [PATCH v4 10/13] oss: Remove unused error handling of qemu_set_fd_handler, Fam Zheng, 2015/06/04
- [Qemu-devel] [PATCH v4 11/13] xen_backend: Remove unused error handling of qemu_set_fd_handler, Fam Zheng, 2015/06/04
- [Qemu-devel] [PATCH v4 12/13] event-notifier: Always return 0 for posix implementation, Fam Zheng, 2015/06/04
- [Qemu-devel] [PATCH v4 13/13] iohandler: Change return type of qemu_set_fd_handler to "void", Fam Zheng, 2015/06/04
- Re: [Qemu-devel] [PATCH v4 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2, Stefan Hajnoczi, 2015/06/05